#3 waiting prompts no going away.

Zavřený
otevřeno před 3 měsíci uživatelem Blance · 3 komentářů

Items like "Loading statics" and "No finished books yet" on the Reading log page still showing after the page is loaded

Items like "Loading statics" and "No finished books yet" on the Reading log page still showing after the page is loaded
Brad Lance okomentoval před 3 měsíci
Vlastník

Fixed in latest commit.

Loading messages and empty state prompts now properly hide when content is loaded.

Changes:

  • Updated renderRecentBooks() in app/static/js/reading-log.js to hide empty state when books are present
  • Added error handling to hide loading indicators even when errors occur
  • Fixed state management to ensure only one state (loading/empty/content) shows at a time
Fixed in latest commit. Loading messages and empty state prompts now properly hide when content is loaded. Changes: - Updated renderRecentBooks() in app/static/js/reading-log.js to hide empty state when books are present - Added error handling to hide loading indicators even when errors occur - Fixed state management to ensure only one state (loading/empty/content) shows at a time
Brad Lance okomentoval před 3 měsíci
Vlastník

the prompt is still there I circled it in red

the prompt is still there I circled it in red
Blance znovuotevřel před 3 měsíci
Brad Lance okomentoval před 3 měsíci
Vlastník

Fixed in commit ad742a6

Root Cause: The CSS file was missing a general .hidden class rule. The JavaScript code was correctly adding/removing the hidden class to toggle visibility of loading indicators (#stats-loading, #books-loading) and empty states (#books-empty), but without the CSS rule, these elements remained visible even after the class was added.

The Fix: Added .hidden { display: none; } to app/static/css/style.css

What This Fixes:

  • Loading indicators now properly disappear after data loads
  • Empty state message only shows when there are no books
  • Stats container and books list toggle visibility correctly

The fix has been tested and deployed.

## Fixed in commit ad742a6 **Root Cause:** The CSS file was missing a general `.hidden` class rule. The JavaScript code was correctly adding/removing the `hidden` class to toggle visibility of loading indicators (`#stats-loading`, `#books-loading`) and empty states (`#books-empty`), but without the CSS rule, these elements remained visible even after the class was added. **The Fix:** Added `.hidden { display: none; }` to `app/static/css/style.css` **What This Fixes:** - Loading indicators now properly disappear after data loads - Empty state message only shows when there are no books - Stats container and books list toggle visibility correctly The fix has been tested and deployed.
Přihlaste se pro zapojení do konverzace.
Bez štítku
Bez milníku
Bez zpracovatele
1 účastníků
Načítání...
Zrušit
Uložit
Není zde žádný obsah.